Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from GdsApi::PublishingApiV2 #1052

Merged
merged 13 commits into from Feb 14, 2020
Merged

Migrate from GdsApi::PublishingApiV2 #1052

merged 13 commits into from Feb 14, 2020

Conversation

huwd
Copy link
Member

@huwd huwd commented Feb 13, 2020

When running tests to tidy up facet groups and business finder code. I noticed a lot of warnings about old test APIs that will be deprecated in future.

Thought, as I'm in here, I'll tidy up.

Followed CLI guidance to move over to new API.

@huwd
Update TestHelpers::PublishingApiV2 to TestHelpers::PublishingApi
517b62f
@huwd
Update test publishing_api_has_item() to stub_publishing_api_has_item()
31e6371
@huwd
Update publishing_api_has_content to stub_publishing_api_has_content
0fb5005
@huwd
Update publishing_api_has_expanded_links to stub_publishing_api_has_e…
3748f57 
…xpanded_links
@huwd
Update publishing_api_has_lookups to stub_publishing_api_has_lookups
0f352a1
@huwd
Update publishing_api_has_linkables to stub_publishing_api_has_linkables
7a9fe6d
@huwd
Update publishing_api_has_links to stub_publishing_api_has_links
b560a7a
@huwd
Update publishing_api_has_linked_items to stub_publishing_api_has_lin…
325ef31 
…ked_items
@huwd
Update content_store_has_item to stub_content_store_has_item
c2c61fe
@huwd
Update publishing_api_does_not_have_item to stub_publishing_api_does_…
a2c2d45 
…not_have_item
@huwd
Fix rubocop errors resulting from test replacement
92a521b
@huwd
Update publishing_api_has_links_for_content_ids to stub_publishing_ap…
759ee40 
…i_has_links_for_content_ids
@huwd
Copy link
Member Author

huwd commented Feb 13, 2020 •
edited

Other things I'll address in other PRs:

Rails 6.1 deprecation warning
Should research and change these from using update_attribtues to update apparently.

User
  behaves like a gds-sso user class
DEPRECATION WARNING: update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead) (called from block (2 levels) in <top (required)> at /home/build/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/gds-sso-14.2.0/lib/gds-sso/lint/user_spec.rb:19)
    implements #update_attributes
    implements #create!
    implements #remotely_signed_out?
    implements #update_attribute
    the User class and GDS::SSO::User mixin work together
    implements #where
    #has_all_permissions?
DEPRECATION WARNING: update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead) (called from block (3 levels) in <top (required)> at /home/build/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/gds-sso-14.2.0/lib/gds-sso/lint/user_spec.rb:33)
      is false when there are no permissions
DEPRECATION WARNING: update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead) (called from block (3 levels) in <top (required)> at /home/build/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/gds-sso-14.2.0/lib/gds-sso/lint/user_spec.rb:39)
      is false when it does not have all required permissions
DEPRECATION WARNING: update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead) (called from block (3 levels) in <top (required)> at /home/build/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/gds-sso-14.2.0/lib/gds-sso/lint/user_spec.rb:45)
      is true when it has all required permissions

Default timeout in sections duplicate definitions
Should research if this is a problem and potentially correct

taxonomy:validate_taxons_base_paths
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: already initialized constant GdsApi::JsonClient::DEFAULT_TIMEOUT_IN_SECONDS
/home/build/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/gds-api-adapters-63.4.0/lib/gds_api/json_client.rb:41: warning: previous definition of DEFAULT_TIMEOUT_IN_SECONDS was here
  optionally fixes paths that do not have the correct level one prefix
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: already initialized constant GdsApi::JsonClient::DEFAULT_TIMEOUT_IN_SECONDS
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: previous definition of DEFAULT_TIMEOUT_IN_SECONDS was here
  outputs check as all-valid
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: already initialized constant GdsApi::JsonClient::DEFAULT_TIMEOUT_IN_SECONDS
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: previous definition of DEFAULT_TIMEOUT_IN_SECONDS was here
  does not fix the base paths by default
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: already initialized constant GdsApi::JsonClient::DEFAULT_TIMEOUT_IN_SECONDS
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: previous definition of DEFAULT_TIMEOUT_IN_SECONDS was here
  skips automatic fix for level one taxons
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: already initialized constant GdsApi::JsonClient::DEFAULT_TIMEOUT_IN_SECONDS
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: previous definition of DEFAULT_TIMEOUT_IN_SECONDS was here
  optionally fixes paths that do not have the correct level one prefix
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: already initialized constant GdsApi::JsonClient::DEFAULT_TIMEOUT_IN_SECONDS
/govuk/content-tagger/lib/tasks/taxonomy/validate_taxons_base_paths.rake:6: warning: previous definition of DEFAULT_TIMEOUT_IN_SECONDS was here
  captures errors that might occur during updates

@huwd huwd changed the title Migrate gds api test helpers Migrate from GdsApi::PublishingApiV2 Feb 13, 2020
@huwd huwd marked this pull request as ready for review February 13, 2020 18:56
@kevindew
Copy link
Member

⭐️ 🏆 🥇

@leenagupte
Copy link
Contributor

👼 🚀 🎉

@huwd huwd merged commit b385b91 into master Feb 14, 2020
@huwd huwd deleted the migrate-gds-api-test-helpers branch February 14, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentqro laurentqro laurentqro approved these changes

@koetsier koetsier Awaiting requested review from koetsier

@vanitabarrett vanitabarrett Awaiting requested review from vanitabarrett

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@huwd @kevindew @leenagupte @laurentqro